[move-function-addr] When inserting compensating destroy_addr, insert debug_value undef before the destroy_addr. #58508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… debug_value undef before the destroy_addr. Otherwise in async contexts we may propagate forward an original non-invalidated debug_value created a use of the invalidated memory. This then causes the MemoryLifetimeVerifier to trigger. I also discovered via this test case that we were not ignoring end_access as a liveness use when visiting non-closure uses. With this change we ignore it now. That being said, the reason why the end_access has not been an issue previously is that due to the hacky way that the move builtin lowers, we actually create the move outside of the relevant access scope (which even worse is a read!). I am going to fix that in a different PR though.
Contributor
Author
|
@swift-ci test |
Contributor
Author
|
I discovered this issue btw while writing tests for the async debug info generation. I just peeled this fix off from that PR into this one so it can be validated separately. |
Contributor
Author
|
@swift-ci test |
Contributor
Author
|
Test passed. The windows test failed in a flaky concurrency test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise in async contexts we may propagate forward an original non-invalidated
debug_value created a use of the invalidated memory. This then causes the
MemoryLifetimeVerifier to trigger.
I also discovered via this test case that we were not ignoring end_access as a
liveness use when visiting non-closure uses. With this change we ignore it
now. That being said, the reason why the end_access has not been an issue
previously is that due to the hacky way that the move builtin lowers, we
actually create the move outside of the relevant access scope (which even worse
is a read!). I am going to fix that in a different PR though.