[SIL Opaque Value] Support checked_cast_br in Address Lowering with loadable source & opaque target type #58441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci smoke test |
atrick
reviewed
Apr 27, 2022
meg-gupta
force-pushed
the
ccbedgecase
branch
4 times, most recently
from
b4f7ce7 to
72ffba9
Compare
Contributor
Author
|
@swift-ci test |
…oadable source type and opaque target type
Contributor
Author
|
@swift-ci smoke test |
atrick
approved these changes
May 5, 2022
Contributor
atrick
left a comment
atrick
left a comment
There was a problem hiding this comment.
Wow, I just skimmed through the cleanup, but it looks great to me. Maybe there are some other places that will need to be cleaned up too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite checked_cast_br instructions that have a loadable source and opaque target as a post pass. Such instructions are not visited by the UseRewriter. All the uses of the opaque block argument are replaced by the storageAddress assigned during the initial allocation. At the end of AddressLowering such checked_cast_br instructions are rewritten to their address forms using this storage address.