Push the debug info for the artificial error inout argument up to SIL. #5481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@SwiftCI please test and merge |
Contributor
Author
|
@swift-ci please test and merge |
Previously IRGen was using a heuristic to assign the argument number to the $error variable that was not generally correct for optimizaed code. This patch inserts a debug_value instruction in SILGen and thus assigns the ArgNo together with all the other function arguments. This is more robust and faster than than the old heuristic. <rdar://problem/28748323>
adrian-prantl
force-pushed
the
28748323
branch
from
dc016f7 to
dddd998
Compare
Contributor
Author
|
@swift-ci please test and merge |
Contributor
Author
|
@swift-ci please test OS X platform |
Contributor
|
Build failed |
Contributor
Author
|
@swift-ci please test OS X platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously IRGen was using a heuristic to assign the argument number
to the $error variable that was not generally correct for optimizaed
code. This patch inserts a debug_value instruction in SILGen and thus
assigns the ArgNo together with all the other function arguments. This
is more robust and faster than than the old heuristic.
rdar://problem/28748323