-
Notifications
You must be signed in to change notification settings - Fork 10.6k
Fix test for 32 bit platforms by removing align from FileCheck pattern. #5422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix test for 32 bit platforms by removing align from FileCheck pattern. #5422
Conversation
|
@swift-ci Please smoke test and merge |
|
@swift-ci Please test and merge |
|
I killed the smoke test and merge, since I want to do a full test here. |
…ust makes the FileCheck handling more complicated.
4e26c29 to
8b7d5e5
Compare
|
@swift-ci Please test and merge |
1 similar comment
|
@swift-ci Please test and merge |
|
"REQUIRES=macosx" is very different from "disable for 32-bit". What are you actually trying to do? |
|
I just wanted to disable it for 32-bit. Otherwise, I would need to create two different runs one for 32 bit and one for 64 bit. That just adds redundant time to the build with no benefit. I am pretty sure since I specified it as an OS check, this is fine. |
|
I'm fine with you disabling 32-bit, but you've also disabled iOS and Linux testing too. That seems like a bad idea. It looks like there's a |
|
One non-disabling solution is:
|
|
@gparker42 yea... I was trying to be lazy and not do that. I think jordan is right about PTRSIZE=64. |
[pull] swiftwasm from main
Fix test for 32 bit platforms by removing align from FileCheck pattern.