Skip to content

[CMake] Don't use hashes in target names #5182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 7, 2016
Merged

[CMake] Don't use hashes in target names #5182

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions cmake/modules/SwiftAddCustomCommandTarget.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,15 +120,9 @@ function(add_custom_command_target dependency_out_var_name)
set(ACCT_COMMANDS ${ACCT_UNPARSED_ARGUMENTS})

if("${ACCT_CUSTOM_TARGET_NAME}" STREQUAL "")
# Construct a unique name for the custom target.
# Use a hash so that the file name does not push the OS limits for filename
# length.
# CMake doesn't allow '/' characters in filenames, so replace them with '-'
list(GET ACCT_OUTPUT 0 output_filename)
string(MD5 target_md5
"add_custom_command_target${CMAKE_CURRENT_BINARY_DIR}/${output_filename}")
get_filename_component(output_filename_basename "${output_filename}" NAME)
set(target_name
"add_custom_command_target-${target_md5}-${output_filename_basename}")
string(REPLACE "/" "-" target_name "${output_filename}")
else()
set(target_name "${ACCT_CUSTOM_TARGET_NAME}")
endif()
Expand Down