SE-0138: Minor update. Array.withUnsafeBytes is nonmutating. #5120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "mutating" keyword should not have been on this API. The example code in SE-0138 uses it as a nonmutating API. (The mutating keyword was a temporary workaround that should never have been carried over to the swift-3.0-branch). <rdar://28614519> [swift-3.0-branch] Remove "mutating" keyword from Array.withUnsafeBytes
Contributor
Author
|
@dabrahams Please review. |
Contributor
Author
|
@swift-ci test. |
Contributor
|
LGTM. Interestingly, the code in the doc comment would not compile with |
Contributor
Author
|
Thanks @moiseev. Can you give this a thumbs up for Swift 3? |
Contributor
|
That's what I used LGTM for. But here is the formal |
.
Contributor
Author
|
CCC |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "mutating" keyword should not have been on this API. The example
code in SE-0138 uses it as a nonmutating API.
(The mutating keyword was a temporary workaround that should never
have been carried over to the swift-3.0-branch).
rdar://28614519 [swift-3.0-branch] Remove "mutating" keyword from Array.withUnsafeBytes