[irgen] Fix linkage of global aliases in case of using the wholemodule optimization with -num-threads #5075
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e optimization with -num-threads. The existing code was not handling the linkage of global aliases in LLVM modules. This resulted in linking errors in certain cases, because the LLVM backend would remove some type metadata in scope of a dead code elimination. Fixes rdar://27245620
Contributor
Author
|
@swift-ci Please test OSX |
Contributor
Author
|
@swift-ci Pleas test OS X |
Contributor
Author
|
@swift-ci Please test OS X |
Contributor
|
Build failed |
Contributor
Author
|
IDE/complete_type.swift failure seems to be totally unrelated. |
Member
|
@swift-ci clean test |
Contributor
Author
|
@tkremenek All tests are green! It can be merged now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
––– CCC Information –––
• Explanation: Fix for a linking error related to missing type metadata symbols.
• Scope of Issue: It can happen if the current module defines an extension of a type from a different module and defines new types inside this extension. The error happens only if the wholemodule optimization with -num-threads option is used, which is a default setting in Xcode.
• Origination: It is a long standing bug. rdar://problem/27245620
• Risk: low.
• Reviewed By: Erik Eckstein
• Testing: Verified locally and using a CI @please smoke test
• Directions for QA: No special directions. The patch includes unit tests.
Detailed description:
The existing code was not handling the linkage of global aliases in LLVM modules. This resulted in linking errors in certain cases, because the LLVM backend would remove some type metadata in scope of a dead code elimination.
Fixes rdar://27245620