In CSDiag, diagnose callee inaccessibility before digging into args. #5063
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci Please smoke test |
Contributor
|
Are you able to merge PRs yourself, @graydon? |
Contributor
Author
|
@slavapestov yes but I figured I ought to get someone to review / approve, no? |
Contributor
|
LGTM @graydon! |
lattner
approved these changes
Oct 5, 2016
lattner
reviewed
Oct 5, 2016
test/NameBinding/accessibility.swift
Outdated
Contributor
There was a problem hiding this comment.
One nit, you shouldn't drop this comment line.
Contributor
Author
There was a problem hiding this comment.
Hah, @DougGregor suggested I remove it!
(the case is labeled by rdar number anyways, and there's git history)
Contributor
Author
There was a problem hiding this comment.
(I put the comment back)
Fixes QoI rdar://problem/27982012
graydon
force-pushed
the
rdar-27982012-poor-diagnostic
branch
from
1a242a1 to
0d5420b
Compare
Contributor
Author
|
@swift-ci please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small fix in diagnostic ordering to prefer noting when a callee is inaccessible before digging into the args (and failing to resolve them against the callee anyways). Replaces an "ambiguous type" error with the true cause.
Noted in QoI rdar://problem/27982012 , test already exists, this just fixes it.