utils: Make update-checkout run in parallel. #5048

erg · 2016-09-28T18:18:16Z

WIP

erg · 2016-09-28T18:18:27Z

swift-ci · 2016-09-28T18:18:44Z

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - 80948b79af716005c7402153b6bae5fffefc9006
Test requested by - @erg

erg · 2016-09-28T18:22:11Z

@swift-ci Please test

swift-ci · 2016-09-28T18:22:22Z

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - 80948b79af716005c7402153b6bae5fffefc9006
Test requested by - @erg

swift-ci · 2016-09-28T18:22:23Z

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - 80948b79af716005c7402153b6bae5fffefc9006
Test requested by - @erg

erg · 2016-09-28T18:22:50Z

@swift-ci Please test

swift-ci · 2016-09-28T18:23:02Z

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - e37afd869beba9befaa37e1d91244c090857e188
Test requested by - @erg

swift-ci · 2016-09-28T18:23:06Z

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - e37afd869beba9befaa37e1d91244c090857e188
Test requested by - @erg

moiseev · 2016-09-28T18:47:47Z

utils/update-checkout


-def update_single_repository(repo_path, branch, reset_to_remote, should_clean,
-                             cross_repo):
+def update_single_repository(args):


Shouldn't it be *args?

Pool.map_async has to call update_single_repository with the fixed five arguments. I unpack them on the second line, maybe that's not as pythonic as it could be? args could be a tuple instead of a list as well.

That is correct, but you can no longer call update_single_repository supplying just those 5 arguments, you'd have to wrap them in either tuple or a list. I just pointed it out as it might cause problems.

erg · 2016-09-28T18:50:31Z

@swift-ci Please test

erg · 2016-09-28T18:51:06Z

@swift-ci Please test

jrose-apple · 2016-09-28T19:02:00Z

I'm a little concerned about this because when I run it over ssh every remote command prompts me for my key password.

erg · 2016-09-28T19:55:48Z

@jrose-apple Well that would stop me from pushing it for sure. I wonder why it's doing that.

jrose-apple · 2016-09-28T20:07:50Z

Sorry, I mean the current one does that. My understanding is that the SSH key server just isn't accessible during an ssh session, or maybe that the key server is associated with a user session and I haven't started one for my ssh session. I suppose that's something I could poke into separately.

erg · 2016-10-07T18:52:59Z

@swift-ci Please test

swift-ci · 2016-10-07T18:53:27Z

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - c02faa9b50c9b4a6fb2f5481b110836d32fd6499
Test requested by - @erg

erg · 2016-10-07T18:58:01Z

@swift-ci Please test

swift-ci · 2016-10-07T19:09:36Z

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - c02faa9b50c9b4a6fb2f5481b110836d32fd6499
Test requested by - @erg

swift-ci · 2016-10-07T19:17:32Z

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - c02faa9b50c9b4a6fb2f5481b110836d32fd6499
Test requested by - @erg

erg · 2016-10-07T21:43:26Z

@swift-ci Please test

swift-ci · 2016-10-07T21:53:45Z

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - c02faa9b50c9b4a6fb2f5481b110836d32fd6499
Test requested by - @erg

swift-ci · 2016-10-07T22:01:31Z

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - c02faa9b50c9b4a6fb2f5481b110836d32fd6499
Test requested by - @erg

erg · 2016-10-17T21:44:15Z

@swift-ci Please test

swift-ci · 2016-10-17T21:47:20Z

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - c02faa9b50c9b4a6fb2f5481b110836d32fd6499
Test requested by - @erg

swift-ci · 2016-10-17T21:47:20Z

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - c02faa9b50c9b4a6fb2f5481b110836d32fd6499
Test requested by - @erg

jrose-apple · 2016-10-17T21:57:08Z

These failures were fixed in #5187. What's going on here?

erg · 2016-10-20T23:12:01Z

Looks like the merge conflict didn't short-circuit the build. Mishal is looking into it.

erg · 2017-01-04T07:38:19Z

@swift-ci Please smoke test

erg · 2017-01-04T08:15:34Z

@swift-ci Please smoke test

erg · 2017-01-04T22:00:11Z

@swift-ci Please clean test

swift-ci · 2017-01-04T22:00:34Z

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - 0ccc8ae0c564702d76d637f2f8a95fa4b5a7cb54
Test requested by - @erg

erg · 2017-01-04T22:00:36Z

@swift-ci Please clean smoke test

swift-ci · 2017-01-04T22:01:05Z

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - 0ccc8ae0c564702d76d637f2f8a95fa4b5a7cb54
Test requested by - @erg

erg · 2017-01-04T22:26:41Z

@swift-ci Please clean smoke test

erg force-pushed the update-checkout-parallel2 branch from 80948b7 to e37afd8 Compare September 28, 2016 18:21

erg force-pushed the update-checkout-parallel2 branch 2 times, most recently from 95a9eb3 to 8f23631 Compare September 28, 2016 18:47

moiseev reviewed Sep 28, 2016

View reviewed changes

erg force-pushed the update-checkout-parallel2 branch from 8f23631 to c02faa9 Compare October 7, 2016 18:52

erg force-pushed the update-checkout-parallel2 branch 2 times, most recently from 8f23631 to 0ccc8ae Compare January 4, 2017 07:37

erg force-pushed the update-checkout-parallel2 branch from 0ccc8ae to 46fdc7a Compare January 4, 2017 08:15

erg force-pushed the update-checkout-parallel2 branch from 46fdc7a to 1985972 Compare January 4, 2017 21:59

erg force-pushed the update-checkout-parallel2 branch 2 times, most recently from f44cbac to 3753f59 Compare January 4, 2017 22:23

utils: Make update-checkout run in parallel.

3753f59

erg merged commit 36f7f74 into swiftlang:master Jan 4, 2017

AnthonyLatsis added the update-checkout Area → utils: the `update-checkout` script label Sep 28, 2022

utils: Make update-checkout run in parallel. #5048

utils: Make update-checkout run in parallel. #5048

Uh oh!

Conversation

erg commented Sep 28, 2016

Uh oh!

erg commented Sep 28, 2016

Uh oh!

swift-ci commented Sep 28, 2016

Uh oh!

erg commented Sep 28, 2016

Uh oh!

swift-ci commented Sep 28, 2016

Uh oh!

swift-ci commented Sep 28, 2016

Uh oh!

erg commented Sep 28, 2016

Uh oh!

swift-ci commented Sep 28, 2016

Uh oh!

swift-ci commented Sep 28, 2016

Uh oh!

moiseev Sep 28, 2016

Choose a reason for hiding this comment

Uh oh!

erg Sep 28, 2016

Choose a reason for hiding this comment

Uh oh!

moiseev Sep 28, 2016

Choose a reason for hiding this comment

Uh oh!

erg commented Sep 28, 2016

Uh oh!

erg commented Sep 28, 2016

Uh oh!

jrose-apple commented Sep 28, 2016

Uh oh!

erg commented Sep 28, 2016

Uh oh!

jrose-apple commented Sep 28, 2016

Uh oh!

erg commented Oct 7, 2016

Uh oh!

swift-ci commented Oct 7, 2016

Uh oh!

erg commented Oct 7, 2016

Uh oh!

swift-ci commented Oct 7, 2016

Uh oh!

swift-ci commented Oct 7, 2016

Uh oh!

erg commented Oct 7, 2016

Uh oh!

swift-ci commented Oct 7, 2016

Uh oh!

swift-ci commented Oct 7, 2016

Uh oh!

erg commented Oct 17, 2016

Uh oh!

swift-ci commented Oct 17, 2016

Uh oh!

swift-ci commented Oct 17, 2016

Uh oh!

jrose-apple commented Oct 17, 2016

Uh oh!

erg commented Oct 20, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

erg commented Jan 4, 2017

Uh oh!

erg commented Jan 4, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

erg commented Jan 4, 2017

Uh oh!

swift-ci commented Jan 4, 2017

Uh oh!

erg commented Jan 4, 2017

Uh oh!

swift-ci commented Jan 4, 2017

erg commented Oct 20, 2016 •

edited

Loading

erg commented Jan 4, 2017 •

edited

Loading