[3.0] Throwing methods must return an object type in the @objc thunk to be @objc #4659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… thunk to be @objc. A throwing method can only be exposed to Objective-C if we can map the return type convention, either because the return type is Void or because it is something that is bridged to an object type (and can therefore be nil to indicate error). Our predicate for checking "bridged to an object type" didn't account for value types that are exposed to (or come from) C, and therefore aren't actually bridged to object types in the Objective-C thunk, meaning they cannot be optional. An existing hack dealt with the largest class of these---types like Int and Bool that can be dynamically bridged to NSNumber---but generalize this by checking exactly how the result type is going to be represented in Objective-C, rejecting '@objc' for cases where the result type won't be an object type. Fixes rdar://problem/28035614 for real. (cherry picked from commit cba7eb9)
(cherry picked from commit 4820453)
|
@swift-ci please test macOS |
|
@jrose-apple , mind taking a look? |
|
@rudkx , you might be interested in this |
|
Huh. Are there any other places left over where we're not using the centralized checking? (LGTM.) |
|
This was the last use of use of |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A throwing method can only be exposed to Objective-C if we can map the
return type convention, either because the return type is
Voidorbecause it is something that is bridged to an object type (and can
therefore be
nilto indicate error). Our predicate for checking"bridged to an object type" didn't account for value types that are
exposed to (or come from) C, and therefore aren't actually bridged to
object types in the Objective-C thunk, meaning they cannot be
optional. An existing hack dealt with the largest class of
these---types like Int and Bool that can be dynamically bridged
to
NSNumber---but generalize this by checking exactly how the resulttype is going to be represented in Objective-C, rejecting
@objcforcases where the result type won't be an object type.
Resolves rdar://problem/28035614.