GSB: Relax -requirement-machine-protocol-signatures=verify check a little #41842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
slavapestov
force-pushed
the
gsb-relax-verify-check
branch
from
2b5cdc5 to
f5aff92
Compare
|
@swift-ci Please smoke test |
…s/ since it passes with the Requirement Machine
…ttle We're getting too many false positives. If the Requirement Machine's result is a prefix of the GSB's result, and the extra requirements produced by the GSB are all same-type parameters, assume it's a GSB bug.
slavapestov
force-pushed
the
gsb-relax-verify-check
branch
from
f5aff92 to
5eb29ae
Compare
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're getting too many false positives. If the Requirement Machine's result is a prefix of the GSB's result, and the extra requirements produced by the GSB are all same-type requirements, assume it's a GSB bug.