IRGen: loosen linkage on vtable stubs for static linking #41604
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The linkage inferred by internal linking is overly restrictive. It uses the "internal linkage type" which is for translation unit local symbols, that is `static` storage. These symbols participate in linking and need to be given external storage but hidden visibility and no DLL storage in static linking. This permits them to participate in symbolic resolution during linking but are made module local, not LLVM module local.
Member
Author
|
CC: @aschwaighofer |
Member
Author
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The linkage inferred by internal linking is overly restrictive. It uses
the "internal linkage type" which is for translation unit local symbols,
that is
staticstorage. These symbols participate in linking and needto be given external storage but hidden visibility and no DLL storage in
static linking. This permits them to participate in symbolic resolution
during linking but are made module local, not LLVM module local.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.