[AST] check modules before recursing for display decls #40860
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci Please test source compatibility |
Contributor
Author
|
@swift-ci Please test |
Contributor
Author
|
After testing locally with one of the original source-compat failures, it seems like this still creates a failure if you try to generate symbol graphs. I'm going to try a different approach and push that up. |
QuietMisdreavus
force-pushed
the
QuietMisdreavus/display-decl-recur
branch
from
f7db5ba to
ed0d6d4
Compare
Contributor
Author
|
@swift-ci Please test source compatibility |
Contributor
Author
|
@swift-ci Please test |
QuietMisdreavus
changed the title
Contributor
|
Build failed |
slavapestov
reviewed
Jan 15, 2022
Contributor
slavapestov
left a comment
slavapestov
left a comment
There was a problem hiding this comment.
Can you add a reduced test case for the crash?
Contributor
|
Build failed |
QuietMisdreavus
force-pushed
the
QuietMisdreavus/display-decl-recur
branch
from
ed0d6d4 to
7338eb0
Compare
Contributor
Author
|
@swift-ci Please test |
Contributor
Author
|
@swift-ci Please test source compatibility |
Contributor
Author
slavapestov
approved these changes
Jan 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves rdar://87601741
In #40810,
ModuleDecl::getDisplayDeclsstarted to recurse into modules that were marked as@_exported importfor collecting decls. This caused some failures in source compatibility testing, due to recursing into Clang modules during serialization that tripped an assertion. This PR adds a check against these modules before recursing, so that Clang modules that should not be recursed into can be skipped.