[5.6] Multiple symbol-graph regressions #40841
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherrypick of #40696 and #40810
Explanation: These resolve issues found in SymbolGraphGen when running during an
-emit-modulecompilation. In the first, access-level information was found to have been preserved inAccessControlattributes, which caused declarations in the symbol graph to start printingpublic(etc) when they previously had not. In the second, symbols declared in headers were not being emitted in symbol graphs, due toSourceFile-based modules not including decls from the underlying Clang module.Scope: Small/Medium. The first is restricted to SymbolGraphGen, while the second affects users of the
ModuleDecl::getDisplayDeclsAPI, including SymbolGraphGen and the module interface printer.Issue: rdar://85280786, rdar://85230067
Risk: Low. The first is restricted to SymbolGraphGen. The second was found to not cause any changes to existing automated tests.
Testing: A new test,
SymbolGraph/ClangImporter/EmitWhileBuilding, has been added to run SymbolGraphGen during an-emit-modulebuild.