Skip to content

[lldb] Add a formatter for swift::Demangle::Node #40568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 14, 2022
Merged

[lldb] Add a formatter for swift::Demangle::Node #40568

merged 1 commit into from
Jan 14, 2022

Conversation

@broadwaylamb
Copy link
Contributor

@broadwaylamb broadwaylamb commented Dec 15, 2021 •
edited
Loading

Before:
Screenshot 2021-12-15 at 19 28 50

After:
Screenshot 2021-12-15 at 19 00 20

@broadwaylamb broadwaylamb force-pushed the demangle-node-lldb-provider branch from aa69dd2 to cb4e203 Compare December 16, 2021 10:59
@augusto2112
Copy link
Contributor

augusto2112 commented Dec 23, 2021

@swift-ci test

@augusto2112
Copy link
Contributor

augusto2112 commented Dec 23, 2021

@swift-ci smoke test

augusto2112
augusto2112 approved these changes Dec 23, 2021
View reviewed changes
Copy link
Contributor

@augusto2112 augusto2112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

@swift-ci
Copy link
Contributor

swift-ci commented Dec 23, 2021

Build failed
Swift Test OS X Platform
Git Sha - cb4e203c540d041a93e44e9257546e199fa5f5b8

@broadwaylamb
Copy link
Contributor Author

broadwaylamb commented Jan 12, 2022

ping

@augusto2112
Copy link
Contributor

augusto2112 commented Jan 12, 2022

@swift-ci smoke test

@augusto2112
Copy link
Contributor

augusto2112 commented Jan 13, 2022

@broadwaylamb it looks like this breaks the python_lint.swift test. Could you update your changes to make the linter happy?

******************** TEST 'Swift-validation(macosx-x86_64) :: Python/python_lint.swift' FAILED ********************
Script:
--
: 'RUN: at line 8';   /Applications/Xcode-beta.app/Contents/Developer/usr/bin/python3 /Users/buildnode/jenkins/workspace/swift-PR-macos-smoke-test/branch-main/swift/utils/python_lint.py
--
Exit Code: 1

Command Output (stdout):
--
./utils/lldb/lldbSwiftDataFormatters.py:76:89: E501 line too long (93 > 88 characters)
./utils/lldb/lldbSwiftDataFormatters.py:83:24: E126 continuation line over-indented for hanging indent
./utils/lldb/lldbSwiftDataFormatters.py:98:9: E722 do not use bare 'except'
./utils/lldb/lldbSwiftDataFormatters.py:112:89: E501 line too long (91 > 88 characters)
./utils/lldb/lldbSwiftDataFormatters.py:113:89: E501 line too long (89 > 88 characters)
./utils/lldb/lldbSwiftDataFormatters.py:114:89: E501 line too long (95 > 88 characters)
./utils/lldb/lldbSwiftDataFormatters.py:127:89: E501 line too long (127 > 88 characters)
./utils/lldb/lldbSwiftDataFormatters.py:141:89: E501 line too long (113 > 88 characters)
./utils/lldb/lldbSwiftDataFormatters.py:149:89: E501 line too long (101 > 88 characters)
./utils/lldb/lldbSwiftDataFormatters.py:152:89: E501 line too long (101 > 88 characters)
./utils/lldb/lldbSwiftDataFormatters.py:153:89: E501 line too long (90 > 88 characters)

@broadwaylamb broadwaylamb force-pushed the demangle-node-lldb-provider branch from cb4e203 to 1ecb947 Compare January 14, 2022 09:49
@broadwaylamb
Copy link
Contributor Author

broadwaylamb commented Jan 14, 2022

@augusto2112 should be fixed.

@augusto2112
Copy link
Contributor

augusto2112 commented Jan 14, 2022

@swift-ci smoke test

@augusto2112
Copy link
Contributor

augusto2112 commented Jan 14, 2022

The windows test failure seems unrelated to this change (module-cache-diagnostics.swift), so I'm merging this. Thanks for doing this @broadwaylamb!

@augusto2112 augusto2112 merged commit a2e7347 into swiftlang:main Jan 14, 2022
@broadwaylamb broadwaylamb deleted the demangle-node-lldb-provider branch January 14, 2022 16:44
@kastiglione kastiglione mentioned this pull request May 12, 2023
Merged
kastiglione added a commit that referenced this pull request May 15, 2023
@kastiglione
[utils] Use --expand in Demangle::Node lldb type summary (#65897)
ab0eeb7 
Without `--expand`, only the summary is shown, no child nodes. Adding `--expand` allows 
for printing the child nodes, to be printed too.

Follow up to #40568
meg-gupta pushed a commit to meg-gupta/swift that referenced this pull request May 22, 2023
@kastiglione @meg-gupta
[utils] Use --expand in Demangle::Node lldb type summary (swiftlang#6…
eda5aed 
…5897)

Without `--expand`, only the summary is shown, no child nodes. Adding `--expand` allows 
for printing the child nodes, to be printed too.

Follow up to swiftlang#40568
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@augusto2112 augusto2112 augusto2112 approved these changes

@kastiglione kastiglione Awaiting requested review from kastiglione

@gottesmm gottesmm Awaiting requested review from gottesmm

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@broadwaylamb @augusto2112 @swift-ci