[SourceKit] Fix a crash that occurred when a document without an associated source file is reopened #40504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
force-pushed
the
pr/fix-snapshot-nullptr-issue
branch
from
67df5b1 to
aa1d745
Compare
Member
Author
|
@swift-ci Please smoke test |
ahoppen
force-pushed
the
pr/fix-snapshot-nullptr-issue
branch
from
aa1d745 to
5c41cfe
Compare
Member
Author
|
@swift-ci Please smoke test |
bnbarham
approved these changes
Dec 10, 2021
Contributor
|
You could use |
Member
Author
|
@swift-ci Please test Windows |
ahoppen
force-pushed
the
pr/fix-snapshot-nullptr-issue
branch
from
5c41cfe to
404e1d9
Compare
…ciated source file is reopened When opening a file for the first time, we don’t store a snapshot for it. This could cause a crash when trying to consult its snapshot to see whether an AST can be reused for cursor info.
ahoppen
force-pushed
the
pr/fix-snapshot-nullptr-issue
branch
from
404e1d9 to
f5b6103
Compare
Member
Author
|
@swift-ci Please smoke test |
Member
Author
|
I couldn’t use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a file isn’t opened with a
key.sourcefileargument, we don’t store a snapshot for it. This could cause a crash when trying to consult its snapshot to see whether an AST can be reused for cursor info.