Skip to content

Conversation

@xymus
Copy link
Contributor

@xymus xymus commented Dec 9, 2021

The flag -check-api-availability-only limits availability checking to the API only, ensuring that what will appear in the swiftinterface is sound without raising issues about implementation details. This patch ensures this mode correctly ignores non-public async functions as they wouldn't appear in the API.

rdar://86174644

-check-api-availability-only limits availability checking to the API
only, ensuring that was will appear in the swiftinterface is sound but
without raising issues about implementation details. This patch ensures
it correctly ignore non-public async functions as they wouldn't appear
in the API.

rdar://86174644
@xymus xymus requested a review from DougGregor December 9, 2021 19:38
@xymus
Copy link
Contributor Author

xymus commented Dec 9, 2021

@swift-ci Please smoke test

@xymus xymus requested review from etcwilde and lorentey December 9, 2021 19:38
Copy link
Member

@etcwilde etcwilde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@lorentey lorentey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉👍

@xymus xymus merged commit 6fd4cc4 into swiftlang:main Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants