Miscellaneous improvements to the cooperative global executor #40198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Switch to using ListMerger for priority insertion. - Move ready delayed jobs to the back to the queue instead of running them immediately, before anything currently in the queue. - Respect priorities in delayed jobs. - Use the proper std::chrono facilities for managing deadlines instead of doing all the math on nanoseconds since the epoch. - Take advantage of the second word of queue-private storage to avoid allocating a separate job when a deadline fits there.
Contributor
Author
|
@swift-ci Please test |
Contributor
Author
|
Windows failure is in LLDB; merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unsigned long longin a million places.ListMergerfor priority insertionstd::chronofacilities for managing deadlines instead of doing all the math on nanoseconds since the epoch.