[ConstraintLocator] Allow simplification of constructor member with overloaded base #40074
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recently added `StmtCondition` and `CastLabelItem` wheren't handled at all.
…verloaded base `init` calls to redeclared types would end up diagnosed as ambiguity, so locator simplification needs to account for the fact that "base" of constructor might be overloaded type reference. Resolves: rdar://84879566
hborla
approved these changes
Nov 6, 2021
Member
hborla
left a comment
hborla
left a comment
There was a problem hiding this comment.
Next stop: remove OverloadedDeclRefExpr
Contributor
Author
|
@swift-ci please clean test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
initcalls to redeclared types would end up diagnosed as ambiguity,so locator simplification needs to account for the fact that "base"
of constructor might be overloaded type reference.
Resolves: rdar://84879566