[SourceKit] Use deep stack when parsing in the XPC service #40066
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@swift-ci Please smoke test |
bnbarham
approved these changes
Nov 5, 2021
Contributor
bnbarham
left a comment
bnbarham
left a comment
There was a problem hiding this comment.
LGTM, nice work on finding that one.
Contributor
|
Could we only wrap the parsing part in a deep-stack |
ahoppen
force-pushed
the
pr/deep-stack
branch
from
75cc9b1 to
d1318da
Compare
ahoppen
changed the title
Member
Author
|
@swift-ci Please smoke test |
Othwerise we were performing the syntactic parsing on a background queue that had a reduced stack size which could result in stack overflows. rdar://84474387
ahoppen
force-pushed
the
pr/deep-stack
branch
from
d1318da to
3a96cc7
Compare
Member
Author
|
Changed it to only switch to a thread with a deep stack when actually performing the parsing and added a test case because we are no longer hitting an assertion failure now that #40065 is merged. |
Member
Author
|
@swift-ci Please smoke test |
akyrtzi
approved these changes
Nov 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Othwerise we were performing the syntactic parsing on a background queue that had a reduced stack size which could result in stack overflows.
rdar://84474387