[stdlib] don't copy array contents on removeAll(keepingCapacity: true)
#39784
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci please test |
Contributor
|
Build failed |
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please test Windows platform |
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
This does not solve the excessive copying problem when keeping a small number of items out an entire copied array, but it is a simple win. Solving the overall problem is much more involved. |
lorentey
approved these changes
Mar 1, 2022
Member
lorentey
left a comment
lorentey
left a comment
There was a problem hiding this comment.
Yay, thanks for fixing this! 🎉
Co-authored-by: Karoy Lorentey <[email protected]>
Co-authored-by: Karoy Lorentey <[email protected]>
Contributor
Author
|
Thanks for the suggestions @lorentey |
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
Note: I would still like to write a benchmark for this case and the "remove all elements but one" case. |
Contributor
Author
|
This change was made in #66085 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling
Array.removeAll(keepingCapacity: true), bypass thereplaceSubrangecall unless the buffer is uniquely referenced.Resolves SR-13923 (rdar://71809690).