DriverTool: add support for WebAssembly autolink entries #39502
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxDesiatov
force-pushed
the
maxd/wasm-autolink-entries
branch
from
372793b to
2687bbf
Compare
MaxDesiatov
force-pushed
the
maxd/wasm-autolink-entries
branch
from
2687bbf to
daceec9
Compare
Contributor
Author
|
@swift-ci please smoke test |
Contributor
Author
78 tasks
Contributor
Author
|
@swift-ci please test Windows platform |
compnerd
approved these changes
Sep 29, 2021
Member
compnerd
left a comment
compnerd
left a comment
There was a problem hiding this comment.
This is rather unfortunate. Since WASM is still relatively new, I still think that we should consider just requiring LLD and falling back to the LLVM extensions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for
.swift1_autolink_entriesin WebAssembly object files tolib/DriverTool/autolink_extract_main.cpp. This is implemented in a similar way to existing ELF autolink entries handling.Related to SR-9307.