-
Notifications
You must be signed in to change notification settings - Fork 10.6k
Added String.init<T>(_: T) and marked it unavailable #3938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@swift-ci please smoke test |
|
Should this have a |
|
I wondered that too, because I think that's the most obvious fix, but I was hesitant to introduce a fix-it along with an alternative. |
|
@dabrahams, what do you think? |
6a4798e to
f8063bb
Compare
|
Spoke with Dave offline. Rename, no message. |
|
@swift-ci please smoke test and merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should provide a fixit hint to do the renaming, right? If so, please add a test for it. Add {{1-2=}} to the end of the expected-error line and run the test. The test will fail and tell you what the right thing is. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, see above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should provide the fixit hint, but it's actually not providing it right now. 🤔
@CodaFi and I are investigating.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I totally read that resolution backwards. My bad.
|
Oh lldb test suite, why are you being so silly today. @swift-ci please smoke test Linux platform. |
f8063bb to
01e4b1e
Compare
|
@swift-ci Please smoke test |
|
@harlanhaskins Could you make a PR for the |
What's in this pull request?
Adds back the
String.init<T>(_: T)initializer with a hint to either conform toLosslessStringConvertibleor useString.init(describing:)Resolved bug number: (SR-2228)
Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
A smoke test on macOS does the following:
device standard libraries are not built.
version of these tests are not run.
A smoke test on Linux does the following:
tests are not run.
Validation Testing
Lint Testing
Note: Only members of the Apple organization can trigger swift-ci.