CMake: disable libdispatch when targeting Wasm/WASI #39274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxDesiatov
force-pushed
the
maxd/wasi-libdispatch
branch
from
af59a7b to
62bdfaf
Compare
Contributor
Author
|
@swift-ci please smoke test |
78 tasks
compnerd
approved these changes
Sep 15, 2021
Member
compnerd
left a comment
compnerd
left a comment
There was a problem hiding this comment.
Sure, this seems fine from a wont break anything for non-WASI, but this really needs to get resolved.
This was referenced Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wasm/WASI doesn't currently support multi-threading, and libdispatch should be disabled when building for this target.
Related to SR-12097.