Sema: Don't try bridged classes as default literal types. #3870
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One last bit of SE-0072. We shouldn't fall back to bridged classes in the absence of type context for literals anymore. By itself, this kind of hoses the use of literals with NS types, but I think we can get most of the QoI back with overlay changes I plan to propose following this.
Contributor
Author
|
@swift-ci Please test |
Contributor
Author
|
@tkremenek I ran the full tests in order to maximize coverage. Would you be able to merge this if the tests pass? |
Contributor
Author
|
@milseman swiftpm fails due to an escaping closure: |
Contributor
|
@milseman said he is going to revert the change. |
Contributor
Author
|
@swift-ci smoke test |
Contributor
Author
|
OS X build fails on playground support, looks related. I'll investigate. |
Member
|
swiftpm should be fine now, builders are passing |
Contributor
Author
|
@milseman Thanks! |
Contributor
Author
|
@swift-ci Please test |
Contributor
Author
|
Fixed the swiftpm failure. Trying again. |
Contributor
Author
|
@swift-ci Please test OS X |
Contributor
|
@jckarter what's the PR for the follow up work? |
Contributor
Author
|
@parkera Haven't filed a public pr yet, but I filed 27616753 internally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One last bit of SE-0072. We shouldn't fall back to bridged classes in the absence of type context for literals anymore. By itself, this kind of hoses the use of literals with NS types, but I think we can get most of the QoI back with overlay changes I plan to propose following this.