Replace @completionHandlerAsync with @available(*, renamed:) #38643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
Few main changes from the commit in the other PR:
|
Contributor
|
Build failed |
bnbarham
force-pushed
the
available-not-completionhandlerasync
branch
from
87648a0 to
1b4e614
Compare
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please test Windows platform |
bnbarham
force-pushed
the
available-not-completionhandlerasync
branch
from
1b4e614 to
b79fd11
Compare
Contributor
|
Build failed |
Contributor
|
Build failed |
bnbarham
force-pushed
the
available-not-completionhandlerasync
branch
from
b79fd11 to
d793390
Compare
Contributor
Author
|
@swift-ci please test |
Instead of a new attribute `@completionHandlerAsync`, allow the use of the existing `renamed` parameter of `@available` to specify the asynchronous alternative of a synchronous function. No errors will be output from invalid names as `@completionHandlerAsync` had, but if a function is correctly matched then it will be used to output warnings when using the synchronous function in an asynchronous context (as before). Resolves rdar://80612731
bnbarham
force-pushed
the
available-not-completionhandlerasync
branch
from
d793390 to
e7e9b57
Compare
Contributor
Author
|
Ah, someone else got module format version number change in before I could merge. Ah well. Last tests passed, will just do a smoke test so I can merge. @swift-ci smoke test |
Contributor
Author
|
@etcwilde I'm going to merge this, but let me know if you think it needs any changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of a new attribute
@completionHandlerAsync, allow the use ofthe existing
renamedparameter of@availableto specify theasynchronous alternative of a synchronous function.
No errors will be output from invalid names as
@completionHandlerAsynchad, but if a function is correctly matched then it will be used to
output warnings when using the synchronous function in an asynchronous
context (as before).
Resolves rdar://80612731