[update-checkout] On Linux for main, next, and master-rebranch, bump the cmake to v3.19.6. #37517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the cmake to v3.19.6. This is not touching the minimum yet since we need to do a bit more work over the next couple of weeks to get the bots ready on macOS for the newer cmake. Windows bots already support the newer cmake. https://forums.swift.org/t/bump-cmake-version-to-3-18/45033/10
shahmishal
approved these changes
May 20, 2021
Member
shahmishal
left a comment
shahmishal
left a comment
There was a problem hiding this comment.
LGTM! Thanks.
Please don't merge this until CI nodes are updated too.
Contributor
Author
|
@shahmishal this won't matter since it will just effect the Linux bots. Won't effect the other bots. |
Contributor
Author
|
@swift-ci test |
Member
We have jobs which don't use update-checkout, so I will need to run different automation to update the tags. |
compnerd
approved these changes
May 20, 2021
Member
|
Jobs updated: |
Member
|
One question: since this only affects linux and the system CMake is used on the Mac and Win CI, what are the deployed CMake versions there? I ask because the minimum CMake version of the three is going to determine what features we can actually use going forward. |
AnthonyLatsis
added
the
update-checkout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not touching the minimum yet since we need to do a bit more work over
the next couple of weeks to get the bots ready on macOS for the newer cmake.
Windows bots already support the newer cmake.
https://forums.swift.org/t/bump-cmake-version-to-3-18/45033/10