[SourceKit/CursorInfo] Enable passing .swiftsourceinfo test #36695
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use-swift-source-info.swift is checking that the .swiftsourceinfo file is being used when OptimizedForIDE is false by checking the location output from a cursor info request. It also checks that the module name is there, which it should be the result is in a different file. There was previously a bug where it *wasn't* added when a location was added (which was valid before .swiftsourceinfo was used). The test has always worked since it was modified in the fix to that bug, but some weirdness caused the change and test to be out of sync (possibly the result of merges between main and next branches). The new line is the language, which was added after it was disabled (and hence missed being updated).
Contributor
Author
|
@swift-ci please test |
nathawes
approved these changes
Apr 1, 2021
Contributor
|
Build failed |
Contributor
Author
|
@swift-ci please clean test Linux platform |
Contributor
|
Build failed |
Contributor
Author
|
@swift-ci please test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use-swift-source-info.swift is checking that the .swiftsourceinfo file
is being used when OptimizedForIDE is false by checking the location
output from a cursor info request.
It also checks that the module name is there, which it should be the
result is in a different file. There was previously a bug where it
wasn't added when a location was added (which was valid before
.swiftsourceinfo was used). The test has always worked since it was
modified in the fix to that bug, but some weirdness caused the change
and test to be out of sync (possibly the result of merges between main
and next branches).
The new line is the language, which was added after it was disabled (and
hence missed being updated).