Skip to content

[CSBinding] Attempt to join any existing and viable bindings with new… #34834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 1, 2020
Merged

[CSBinding] Attempt to join any existing and viable bindings with new… #34834

merged 1 commit into from
Dec 1, 2020

Conversation

@xedin
Copy link
Contributor

@xedin xedin commented Nov 19, 2020

… binding

Instead of attempting to join only the last recorded supertype
binding, let's attempt to join any previously recorded supertype
binding with an incoming one to make sure that set contains only
the most viable types.

@xedin xedin requested a review from hborla November 19, 2020 21:05
@xedin
Copy link
Contributor Author

xedin commented Nov 19, 2020

@swift-ci please test source compatibility

@xedin
Copy link
Contributor Author

xedin commented Nov 19, 2020

@swift-ci please test

LucianoPAlmeida
LucianoPAlmeida reviewed Nov 20, 2020
View reviewed changes
@xedin
Copy link
Contributor Author

xedin commented Nov 20, 2020

Looks like there are two failures (Kighfisher, Surge) which both has to do with:

/Applications/Xcode-beta.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.0.sdk/usr/lib/swift/Accelerate.swiftmodule/x86_64-apple-macos.swiftinterface:5348:11: error: 'Float16' is unavailable: Float16 is not available on target platform.
extension Float16 : Accelerate.BNNSScalar {
          ^~~~~~~
Swift.Float16:2:23: note: 'Float16' has been explicitly marked unavailable here
@frozen public struct Float16 {
                      ^

I wonder whether this is related to changes here or something else...

@xedin
Copy link
Contributor Author

xedin commented Nov 20, 2020

Ah, looks like this is due to Make Float16 available for macOS on Apple Silicon (#34821)

@xedin xedin mentioned this pull request Nov 20, 2020
Merged
@xedin
[CSBinding] Attempt to join any existing and viable bindings with new…
96415b2 
… binding

Instead of attempting to join only the last recorded supertype
binding, let's attempt to join any previously recorded supertype
binding with an incoming one to make sure that set contains only
the most viable types.
@xedin xedin force-pushed the replace-last-supertype-index branch from 81ac1f4 to 96415b2 Compare November 20, 2020 02:06
@swift-ci
Copy link
Contributor

swift-ci commented Nov 20, 2020

Build failed
Swift Test OS X Platform
Git Sha - 81ac1f4b2950b6da26e1d376eeee8219b4cf5ea5

@xedin
Copy link
Contributor Author

xedin commented Nov 20, 2020

@swift-ci please smoke test

@xedin
Copy link
Contributor Author

xedin commented Nov 20, 2020

@swift-ci please smoke test macOS platform

@xedin
Copy link
Contributor Author

xedin commented Nov 20, 2020

@swift-ci please smoke test Linux platform

@xedin
Copy link
Contributor Author

xedin commented Dec 1, 2020

@swift-ci please smoke test

@xedin
Copy link
Contributor Author

xedin commented Dec 1, 2020

@swift-ci please test source compatibility debug

@xedin xedin merged commit 57a2e11 into swiftlang:main Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hborla hborla hborla approved these changes

+1 more reviewer

@LucianoPAlmeida LucianoPAlmeida LucianoPAlmeida left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@xedin @swift-ci @LucianoPAlmeida @hborla