[NFC] Spin Off Dependency Tracing Utilities From FrontendTool #34694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci smoke test |
davidungar
approved these changes
Nov 12, 2020
Contributor
davidungar
left a comment
davidungar
left a comment
There was a problem hiding this comment.
LGTM! I like the constification. There were one or two places where a const reference could maybe be used.
Contributor
There was a problem hiding this comment.
Just a thought: would it work to use a const reference here?
Contributor
Author
There was a problem hiding this comment.
It would. But if the goal is to prevent reassignment, encapsulation is your best bet.
Contributor
Author
|
@swift-ci smoke test Linux |
T *const does not prevent logically non-const accesses to the underlying data, it merely indicates that the pointer value itself is const. This modifier can be cast off by a copy, so it's not generally what you want here. Switch to const T * instead.
CodaFi
force-pushed
the
frontend-loader
branch
from
e163a20 to
19e6bee
Compare
Contributor
Author
|
@swift-ci smoke test |
Contributor
Author
|
@swift-ci smoke test macOS |
Contributor
Author
|
⛵ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This leaves FrontendTool devoid of everything except the high-level entrypoints to functionality in the rest of the compiler stack. Hopefully we can make a later pass and drop a bunch of unused includes...