Skip to content

Conversation

@varungandhi-apple
Copy link
Contributor

@varungandhi-apple varungandhi-apple commented Oct 30, 2020

First two commits are from #34513 and can be ignored here.

@varungandhi-apple
Copy link
Contributor Author

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 68cff14152bc761ccf5e4a49c6933a7426a48754

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 68cff14152bc761ccf5e4a49c6933a7426a48754

@varungandhi-apple
Copy link
Contributor Author

@swift-ci please test

1 similar comment
@varungandhi-apple
Copy link
Contributor Author

@swift-ci please test

Copy link
Contributor

@rjmccall rjmccall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Also remove the original implementation from GenClangType.cpp
since it isn't used anymore.
@varungandhi-apple varungandhi-apple force-pushed the vg-irgen-remove-old-clangtypeconverter branch from 68cff14 to 0484f3a Compare November 12, 2020 18:32
@varungandhi-apple
Copy link
Contributor Author

@swift-ci please test and merge

@swift-ci swift-ci merged commit e89b534 into swiftlang:main Nov 12, 2020
@varungandhi-apple varungandhi-apple deleted the vg-irgen-remove-old-clangtypeconverter branch November 12, 2020 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants