WinSDK: add Shell32 #33849
WinSDK: add Shell32 #33849
Conversation
This header and .lib features useful APIs such as [SHFileOperation](https://docs.microsoft.com/en-us/windows/win32/api/shellapi/nf-shellapi-shfileoperationw), which seems to be the preferred way to manipulate file systems for certain things.
|
@swift-ci smoke test |
|
@swift-ci smoke test Windows Platform |
|
smoke test Linux Platform |
compnerd
left a comment
compnerd
left a comment
There was a problem hiding this comment.
Hmm, I'm wondering if we want to rename the old module or not. The original module is the lightweight Shell API, and this is the full one. Either way, as long as it builds, this seems reasonable, but I would like to test the build locally, since we're missing coverage on Foundation :(. I learnt the hard way with the last rebranch.
|
ah. The only test I ran locally is modifying the installed .modulemap and use one of the APIs in the local build. It appeared to have worked well. |
|
@swift-ci smoke test Linux Platform |
compnerd
left a comment
compnerd
left a comment
There was a problem hiding this comment.
Seems that I can build Foundation with this change just fine. Still not sure about how to best handle the lightweight vs full API surface for shell, but that can be improved as a follow up.
|
@swift-ci please smoke test Linux platform |
2 participants
This header and .lib features useful APIs such as SHFileOperation, which seems to be the preferred way to manipulate file systems for certain things.