Revert "[IRGen] Use the lexical decl context for VarDecls." #33813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@swift-ci please smoke test |
Member
|
Sorry; do I need to create a new PR to include the fix? |
Member
Author
|
@3405691582 oh, you already have a fix? in that case, could you please create a PR? we should get that merged instead. |
Member
|
Added a PR to fix forward; I can cherry pick in the linked PR and recommit on that PR if that's preferred. |
Member
Author
|
Superseded by #33816 |
3405691582
added a commit
to 3405691582/swift
that referenced
this pull request
Sep 5, 2020
Windows IR seems to include a `dso_local` annotation, which the check didn't expect and caused a failure in swiftlang#33813. Added a regex check to ensure the test passes with or without the annotation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #33306