[ConstraintSystem] Record generic fix if destination of a pointer con… #33809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…version is invalid If the right-hand side (destination) of value-to-pointer conversion is incorrect e.g. base type of member is a hole, let's record a generic "invalid conversion" failure. Resolves: rdar://problem/68254165
xedin
commented
Sep 4, 2020
| //problem/68254165 - Bad diagnostic when using String init(decodingCString:) with an incorrect pointer type | ||
| func rdar68254165(ptr: UnsafeMutablePointer<Int8>) { | ||
| _ = String(decodingCString: ptr, as: .utf8) // expected-error {{generic parameter 'Encoding' could not be inferred}} | ||
| // expected-error@-1 {{type '_.Type' has no member 'utf8'}} |
Contributor
Author
There was a problem hiding this comment.
New HoleType allows us to deal with this issue and avoid producing member diagnostic here. I'm going to implement that in a follow-up PR to separate concerns here...
Contributor
Author
|
@swift-ci please smoke test |
Contributor
Author
|
@swift-ci please smoke test macOS platform |
hborla
approved these changes
Sep 4, 2020
Contributor
Author
|
@swift-ci please smoke test macOS platform |
Contributor
Author
|
@swift-ci please smoke test Windows platform |
Contributor
Author
|
@swift-ci please smoke test macOS platform |
1 similar comment
Contributor
Author
|
@swift-ci please smoke test macOS platform |
Contributor
Author
|
Windows failure is caused by #33306 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…version is invalid
If the right-hand side (destination) of value-to-pointer conversion
is incorrect e.g. base type of member is a hole, let's record
a generic "invalid conversion" failure.
Resolves: rdar://problem/68254165