Remove -enable-astscope-lookup flag #33805
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci Please smoke test |
davidungar
approved these changes
Sep 4, 2020
Contributor
davidungar
left a comment
davidungar
left a comment
There was a problem hiding this comment.
So nice to see the old stuff go! My one comment is maybe the title of the PR, and/or the description needs more explanation. The changes go beyond, although may be a consequence of, just removing one flag.
lib/Sema/TypeCheckStmt.cpp
Outdated
Comment on lines
-678
to
-740
Contributor
There was a problem hiding this comment.
It's not obvious that this change belongs in a PR named "remove ... flag". Was it only used to cross-check ASTScopes?
Contributor
Author
There was a problem hiding this comment.
This is the old implementation of fall-through case statements. It's no longer needed since we can always use the new implementation. This change is also in a separate commit.
slavapestov
force-pushed
the
remove-enable-astscope-lookup-flag
branch
from
4369aca to
193cf0d
Compare
Contributor
Author
|
@swift-ci Please smoke test |
dabrahams
pushed a commit
that referenced
this pull request
Sep 14, 2020
-enable-astscope-lookup was removed in #33805
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.