Skip to content

Conversation

@owenv
Copy link
Contributor

@owenv owenv commented Aug 22, 2020

This will support swiftlang/swift-package-manager#2653, which adopts ArgumentParser in SPM. It'll require CI reconfiguration before merging.

Copy link
Contributor

@abertelrud abertelrud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks!

@shahmishal
Copy link
Member

@swift-ci test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - c63dba64912edc4c7f298712e69e223a08a23afb

@owenv
Copy link
Contributor Author

owenv commented Aug 24, 2020

@swift-ci please test Linux

@abertelrud
Copy link
Contributor

Looks like all test are now passing, so we just need @shahmishal's approval, and can then merge.

@shahmishal
Copy link
Member

Jobs updated, can you also update the "master-rebranch" scheme?

@owenv
Copy link
Contributor Author

owenv commented Aug 25, 2020

@shahmishal thanks!

@owenv
Copy link
Contributor Author

owenv commented Aug 25, 2020

@swift-ci test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - c63dba64912edc4c7f298712e69e223a08a23afb

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - c63dba64912edc4c7f298712e69e223a08a23afb

@owenv
Copy link
Contributor Author

owenv commented Aug 25, 2020

@swift-ci please test macOS

@shahmishal shahmishal merged commit 63a8463 into swiftlang:master Aug 25, 2020
@AnthonyLatsis AnthonyLatsis added the update-checkout Area → utils: the `update-checkout` script label Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

update-checkout Area → utils: the `update-checkout` script

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants