Add default IR attributes to helper functions #33379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci Please test |
Contributor
|
Build failed |
Contributor
|
Build failed |
several more places to use getOrCreateHelperFunction. This means that several of these places are now emitting shared functions rather than private ones, which I've verified is okay. There are some other places where privacy is still unfortunately necessary. I've also fixed the name of the store-extra-inhabitants helper function to say "store" instead of "get", which is longstanding (but harmless because it's private). Fixes rdar://66707994.
rjmccall
force-pushed
the
default-attribute-helpers
branch
from
c3708d9 to
03d94b4
Compare
Contributor
Author
|
@swift-ci Please test. |
rjmccall
requested review from
aschwaighofer and
jckarter
and removed request for
jckarter
Contributor
|
Build failed |
Contributor
|
Build failed |
Member
|
CC: @shahmishal - seems that the Windows CI didn't trigger here? One of the changes has a mix up that would've been caught by the CI. |
compnerd
added a commit
to compnerd/apple-swift
that referenced
this pull request
Aug 9, 2020
The order of attribution was swapped which failed on platforms which use `comdat` (i.e. Windows).
compnerd
added a commit
that referenced
this pull request
Aug 10, 2020
test: repair Serialization.autolinking after #33379
compnerd
added a commit
to compnerd/apple-swift
that referenced
this pull request
Aug 20, 2020
The order of attribution was swapped which failed on platforms which use `comdat` (i.e. Windows).
tkremenek
added a commit
that referenced
this pull request
Aug 25, 2020
test: repair Serialization.autolinking after #33379
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add default IR attributes to helper functions and convert several more places to use
getOrCreateHelperFunction.This means that several of these places are now emitting shared functions rather than private ones, which I've verified is okay. There are some other places where privacy is still unfortunately necessary.
I've also fixed the name of the store-extra-inhabitants helper function to say "store" instead of "get", which is longstanding (but harmless because it's private).
Fixes rdar://66707994.