[5.3] IRGen: ObjC method lists are not const. #33338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Put them in __objc_data instead of __objc_const. rdar://problem/66630432
Contributor
Author
|
@swift-ci Please test |
Contributor
Author
|
@swift-ci Please nominate |
airspeedswift
approved these changes
Aug 10, 2020
AnthonyLatsis
added
swift 5.3
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: We incorrectly placed method lists in
__DATA,__objc_const, causing us to dirty pages in the shared cache that are intended to remain cleanScope: Performance issue
Issue: rdar://problem/66630432
Risk: Low. Should be no impact to end user code
Testing: Swift CI
Reviewed by: @mikeash