Skip to content

Conversation

@theblixguy
Copy link
Collaborator

When collecting callees for an unresolved member (like .foo), if the type is optional then also check the base type for any callees. Otherwise, code completion will not be able to suggest argument labels for a call.

struct S {
  static func foo(arg: Int) -> Self { return S() }
}

let s: S? = .foo(#^COMPLETE^#) // should suggest 'arg'

Resolves SR-13340
Resolves rdar://problem/66490100

@theblixguy theblixguy requested a review from nathawes August 4, 2020 20:57
@nathawes nathawes requested a review from rintaro August 4, 2020 21:01
Copy link
Member

@rintaro rintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you!

@theblixguy
Copy link
Collaborator Author

theblixguy commented Aug 5, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants