Type substitution: When substituting SILFunctionTypes we substitute unbound Objective-C generic for bound ones (take 2) #33211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nbound Objective-C generic for bound ones (take 2) IRGen does so. So don't assert on the case when there is a nested Objective-C type. (follow-up to swiftlang#32027 rdar://63509292 which fixed the non-nested case) rdar://66302139
Contributor
Author
|
@swift-ci Please test |
Contributor
|
Build failed |
Contributor
Author
|
@swift-ci Please test os x platform |
jckarter
approved these changes
Jul 30, 2020
Contributor
jckarter
left a comment
jckarter
left a comment
There was a problem hiding this comment.
Thanks Arnold! Nice catch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IRGen does so. So don't assert on the case when there is a nested
Objective-C type.
(follow-up to #32027 rdar://63509292 which fixed the non-nested case)
rdar://66302139