[NFC] Stash Syntactic Information in EnumIsCaseExpr #33049
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After the TypeLocs were removed here, the TypeRepr from the IsExpr was the only thing providing access to syntactic information from the parent IsExpr. In order to support this, it was possible to construct a bizarre ConditionalCheckedCastExpr that contained both semantic and syntactic information. This doesn't comport with the rest of the casting nodes, which force you to pick one or the other. Since we're rewriting an IsExpr into a EnumIsCaseExpr, let's just stash the syntactic information there. This unblocks a bit of cleanup.
Contributor
Author
|
@swift-ci smoke test and merge |
Contributor
Author
|
@swift-ci smoke test macOS platform |
slavapestov
approved these changes
Jul 22, 2020
Contributor
Author
|
⛵ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the TypeLocs were removed here, the TypeRepr from the IsExpr was
the only thing providing access to syntactic information from the parent
IsExpr. In order to support this, it was possible to construct a bizarre
ConditionalCheckedCastExpr that contained both semantic and syntactic
information. This doesn't comport with the rest of the casting nodes,
which force you to pick one or the other.
Since we're rewriting an IsExpr into a EnumIsCaseExpr, let's just stash
the syntactic information there. This unblocks a bit of cleanup.