Skip to content

Conversation

@compnerd
Copy link
Member

In order to deal with encoding conversions for Python 2 and Python 3,
the string had to be passed through CStringIO for Python 2. On Python
3, the strings are unicode.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

In order to deal with encoding conversions for Python 2 and Python 3,
the string had to be passed through CStringIO for Python 2.  On Python
3, the strings are unicode.
@compnerd
Copy link
Member Author

CC: @tbkka @drexin @tachoknight

@compnerd
Copy link
Member Author

@swift-ci please test

Copy link
Contributor

@drexin drexin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@compnerd compnerd merged commit 9fd6df6 into swiftlang:master Jul 22, 2020
@compnerd compnerd deleted the list branch July 22, 2020 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants