[SourceKit/DocSupport] Don't synthesize extensions for inherited protocol conformances. #33031
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ocol conformances. The Base class already includes them, so don't duplicate them in its subclasses. Also stops us including members from extensions of the base class itself. Resolves rdar://problem/50960433
Contributor
Author
|
@swift-ci please test |
Contributor
|
Build failed |
Contributor
Author
|
@swift-ci please test OS X Platform |
akyrtzi
approved these changes
Jul 21, 2020
Contributor
|
Build failed |
Contributor
Author
|
Failure seems unrelated: |
Contributor
Author
|
@swift-ci please smoke test OS X Platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The base class will include them, so don't duplicate them in its subclasses. Also stops us including members from extensions of the base class itself.
Resolves rdar://problem/50960433