Skip to content

Conversation

@LucianoPAlmeida
Copy link
Contributor

When we have a generic argument binding failure from a Bind constraint that is based on generic requirements e.g. String bind $T6.Element constraint, handle this on repairFailures and diagnosing the requirement fix.

Resolves SR-13226.

@LucianoPAlmeida LucianoPAlmeida requested review from hborla and xedin July 18, 2020 22:09
@LucianoPAlmeida LucianoPAlmeida force-pushed the SR-13226-constraint-requirement branch from 6a548c3 to 033eb48 Compare July 20, 2020 02:08
@LucianoPAlmeida LucianoPAlmeida force-pushed the SR-13226-constraint-requirement branch from 033eb48 to 82d95ec Compare July 21, 2020 03:23
@LucianoPAlmeida LucianoPAlmeida requested a review from xedin July 21, 2020 03:35
Copy link
Contributor

@xedin xedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@xedin
Copy link
Contributor

xedin commented Jul 21, 2020

@swift-ci please smoke test

@LucianoPAlmeida LucianoPAlmeida merged commit 6775949 into swiftlang:master Jul 21, 2020
@LucianoPAlmeida LucianoPAlmeida deleted the SR-13226-constraint-requirement branch July 21, 2020 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants