Skip to content

[AutoDiff][stdlib] Add JVPs to ArrayDifferentiation.swift #32840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 12, 2020
Merged

[AutoDiff][stdlib] Add JVPs to ArrayDifferentiation.swift #32840

merged 5 commits into from
Jul 12, 2020

Conversation

efremale
Copy link
Contributor

@efremale efremale commented Jul 11, 2020 •
edited
Loading

Adds JVPs to Array and Array.DifferentiableView

_jvpDifferentiableReduce is taken from #29324

@efremale
Copy link
Contributor Author

cc @dan-zheng

@dan-zheng dan-zheng requested review from marcrasi and rxwei July 12, 2020 00:24
dan-zheng
dan-zheng approved these changes Jul 12, 2020
View reviewed changes
Copy link
Contributor

@dan-zheng dan-zheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@dan-zheng
Copy link
Contributor

@swift-ci Please smoke test

@dan-zheng dan-zheng merged commit bfcf12b into swiftlang:master Jul 12, 2020
This was referenced Jul 15, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rxwei rxwei rxwei approved these changes

@dan-zheng dan-zheng dan-zheng approved these changes

@marcrasi marcrasi Awaiting requested review from marcrasi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@efremale @dan-zheng @rxwei