[sourcekit] Retain semantic annotations across queries #32628
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not remove semantic annotations, so that if a client sends multiple magic replacetext 0, 0, "" requests they will all return the same result. This makes sourcekitd more robust around providing semantic highlighting if the editor may make multiple queries for document update. rdar://64904029
Contributor
Author
|
@swift-ci please test |
akyrtzi
approved these changes
Jun 30, 2020
Contributor
Author
|
@swift-ci please test |
1 similar comment
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please test Windows |
1 similar comment
Contributor
Author
|
@swift-ci please test Windows |
jirid
pushed a commit
to jirid/swift
that referenced
this pull request
Jul 15, 2020
…e-master Revert "Merge pull request swiftlang#32628 from benlangmuir/sema-repeat"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not remove semantic annotations, so that if a client sends multiple
magic
replacetext 0, 0, ""requests they will all return the sameresult. This makes sourcekitd more robust around providing semantic
highlighting if the editor may make multiple queries for document
update.
rdar://64904029