[Diagnostics][Sema] Error type derived conformances #32371
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theblixguy
reviewed
Jun 14, 2020
LucianoPAlmeida
force-pushed
the
error-type-derived-conformance
branch
from
1b0f510 to
d240a52
Compare
LucianoPAlmeida
force-pushed
the
error-type-derived-conformance
branch
2 times, most recently
from
7b7d9d1 to
b7ab7da
Compare
theblixguy
reviewed
Jun 16, 2020
Contributor
Author
Contributor
Author
|
I'm definitely not sure, since what we are doing here is just handle early a possible error type which is more general, and avoid re-validate a re-declaration which even with no error maybe makes sense :) |
LucianoPAlmeida
force-pushed
the
error-type-derived-conformance
branch
from
1695d2e to
405120b
Compare
LucianoPAlmeida
force-pushed
the
error-type-derived-conformance
branch
2 times, most recently
from
3ed07a4 to
3458548
Compare
AnthonyLatsis
approved these changes
Jun 21, 2020
Collaborator
AnthonyLatsis
left a comment
AnthonyLatsis
left a comment
There was a problem hiding this comment.
Thank you for pursuing this, Luciano!
Contributor
Author
|
All adjusted @AnthonyLatsis :) |
Contributor
Author
|
Ping @CodaFi, Could you give a quick look at this? :) |
LucianoPAlmeida
force-pushed
the
error-type-derived-conformance
branch
from
fb53bed to
344662e
Compare
Contributor
Author
xedin
reviewed
Jul 3, 2020
LucianoPAlmeida
force-pushed
the
error-type-derived-conformance
branch
from
344662e to
ade4536
Compare
…Enum to not record duplicated member and skip diagnostics on malformed types
LucianoPAlmeida
force-pushed
the
error-type-derived-conformance
branch
from
ade4536 to
f94d394
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auditing for possible incorrect diagnostics that mention error types in some way found this
of derived conformances :)