[5.3][preset] Add missing libicu dependencies to package presets #32316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were accidentally using the system libicu instead of building it, causing version mismatches. This will unblock Linux PR testing for swiftlang/swift-llbuild#674 (cherry picked from commit ccb41f0, swiftlang#31733)
Contributor
Author
|
Please test with following pull request: @swift-ci Please smoke test |
Contributor
Author
|
Please test with following pull request: @swift-ci Please test |
Contributor
Author
|
Please test with following pull request: @swift-ci Please clean test Windows platform |
shahmishal
approved these changes
Jun 11, 2020
benlangmuir
approved these changes
Jun 11, 2020
AnthonyLatsis
added
swift 5.3
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were accidentally using the system libicu instead of building it,
causing version mismatches.
This will unblock Linux PR testing for
swiftlang/swift-llbuild#674
(cherry picked from commit ccb41f0,
#31733)