Skip to content

[5.3][SourceKit] Disable labeled trailing closure support except code completion #32315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 11, 2020
Merged

[5.3][SourceKit] Disable labeled trailing closure support except code completion #32315

merged 1 commit into from
Jun 11, 2020

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Jun 11, 2020 •
edited
Loading

Cherry-pick of #32276 into release/5.3

  • Explanation: This patch fixes an issue where conforming method list returns nothing for call expression with trailing closures. "code completion" and other completion-like operations including "conforming method list" are using the same mechanism for type checking parsed expressions. When "multiple trailing closures" are introduced, "conforming method list" request was not implemented to handle them.
  • Scope: Conforming method list request for calling expression with trailing closure
  • Risk: Low. This only affects "conforming method list" request
  • Testing: Added a regression test case
  • Issue: rdar://problem/63781922
  • Reviewer: Ben Langmuir (@benlangmuir)

@rintaro
[SourceKit] Disable labeled trailing closure support except code comp…
8f1415c 
…letion

Don't insert CodeCompletionExpr at the cursor position in
"conforming method list" or "typecontext" mode. This increase the chance
of successful type checking.

rdar://problem/63781922
(cherry picked from commit 67e88f4)
@rintaro rintaro added the r5.3 label Jun 11, 2020
@rintaro rintaro requested a review from a team as a code owner June 11, 2020 16:03
@rintaro
Copy link
Member Author

rintaro commented Jun 11, 2020

@swift-ci Please test

@rintaro
Copy link
Member Author

rintaro commented Jun 11, 2020

@swift-ci Please nominate

@tkremenek tkremenek merged commit 991cc3f into swiftlang:release/5.3 Jun 11, 2020
@AnthonyLatsis AnthonyLatsis added swift 5.3 🍒 release cherry pick Flag: Release branch cherry picks labels Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkremenek tkremenek tkremenek approved these changes

Assignees
No one assigned
Labels
🍒 release cherry pick Flag: Release branch cherry picks swift 5.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rintaro @tkremenek @AnthonyLatsis