[5.3][memory-lifetime] Teach the verifier that select_enum_addr doesn't write to memory. #32273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ite to memory. This is an older verifier that checks that uses of addresses from things like in_guaranteed parameters are never written to. We just never hit this before. <rdar://problem/63188699> (cherry picked from commit ebf291c)
Contributor
Author
|
@swift-ci test |
gottesmm
changed the title
meg-gupta
approved these changes
Jun 9, 2020
Contributor
Author
|
Thanks! |
Contributor
Author
|
@swift-ci nominate |
airspeedswift
approved these changes
Jun 10, 2020
AnthonyLatsis
added
swift 5.3
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an older verifier that checks that uses of addresses from things like
in_guaranteed parameters are never written to. We just never hit this before.
rdar://problem/63188699
(cherry picked from commit ebf291c)
Explanation: This is just eliminating a false positive case to a verifier that we only run when assertions are enabled. By fixing this, we ensure that when qualifying with an asserts compiler we do not hit this case.
Scope: This doesn't break source or anything of the sort but just helps us to qualify using assert compilers.
SR Issue: rdar://problem/63188699
Risk: None. This only is run in asserts builds.
Testing: Added an example to the swift test suite to make sure we accept this pattern.
Reviewer: @meg-gupta